swift-server / swift-server/async-http-client

latest SwiftFormat not matching the current formatting

Open
#359 0 comments 0 reactions 1 assignee View on GitHub

@tomerd is already working on this.

Since May 6, 2021.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

Unfortunately, there's a real issue with using SwiftFormat in an automated way: SwiftFormat seems to randomly change its default formatting.

That means that to pass the AHC CI you'll need to install the very SwiftFormat version that is in use here.

And even updating SwiftFormat in AHC's CI isn't really going to fix the issue because that will needlessly reformat the whole source, obliterating git blame :(.

We need a proper solution here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.