swift-server / swift-server/async-http-client

Support HTTP/1.1 Upgrade to raw TCP stream

Open
#353 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

I notice that my code fails after (fail if user tries writing bytes after request is sent #270) change.

Background:
I use this API https://docs.docker.com/engine/api/v1.41/#operation/ContainerAttach that hijack the connection and allow to send back body after the request is sent. The connection stays active and the server expects and accepts more data.

Problem:
After the change, HTTPHandler rejects further writes to body, thas is undesired in this scenario.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with HTTPHandler and the behavior changed by PR #270, then review the Docker Container Attach API's hijacked connection requirements. The work is complete when an HTTP/1.1 upgrade can keep the connection active and allow body writes after the request is sent without HTTPHandler rejecting them.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.