swift-server / swift-server/async-http-client

Support macCatalyst

Open
#304 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

AsyncHTTPClient 1.2.1 commit hash: 4b4d6605aa2e4f0c2ae3c7563795ae3bec259fff

Context:
Building AsyncHTTPClient for Mac Catalyst fails with errors:

'sec_protocol_options_set_tls_min_version' is unavailable in Mac Catalyst
'sec_protocol_options_set_tls_max_version' is unavailable in Mac Catalyst

Steps to reproduce:

  1. Open Package.swift in Xcode
  2. Select platform My Mac (Mac Catalyst)
  3. Build

$ swift --version
Apple Swift version 5.2.4 (swiftlang-1103.0.32.9 clang-1103.0.32.53)
Target: x86_64-apple-darwin19.6.0

Operating system: macOS Catalina 10.15.6

$ uname -a
Darwin xxx 19.6.0 Darwin Kernel Version 19.6.0: Thu Jun 18 20:49:00 PDT 2020; root:xnu-6153.141.1~1/RELEASE_X86_64 x86_64

Xcode 11.6
Mac Catalyst 13.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by opening Package.swift in Xcode and reproducing the Mac Catalyst build with the versions and platform listed in the issue. Trace the uses of sec_protocol_options_set_tls_min_version and sec_protocol_options_set_tls_max_version, then verify that AsyncHTTPClient builds successfully for Mac Catalyst without those availability errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
mobile-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.