swift-server / swift-server/async-http-client
HTTPClient.Body.stream uses Int for the size. Should this be Int64?
Open
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
I know we are most likely to be running on a 64 bit system and Int will be 64 bits but one of the systems that HTTPClient.Body.stream is most likely to interact with is NonBlockingFileIO. This uses Int64 for file size, offsets into files.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at HTTPClient.Body.stream and compare its size type with NonBlockingFileIO's Int64 file size and offsets. Determine whether the public API should use Int64, including the compatibility implications, and document or test the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, backend-api-design
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100