swift-server / swift-server/async-http-client

Add NIOSSLCustomVerificationCallback for HTTPClient

Open
#285 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

We're using pin the public key for ssl-pinning, but there is no way to use NIOSSLCustomVerificationCallback in the NIOSSLClientHandler .

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading NIOSSLClientHandler and the existing public-key pinning path to understand how SSL verification is configured. Then check how NIOSSLCustomVerificationCallback can be exposed for HTTPClient; done means callers can use that callback alongside the current pinning setup and the relevant verification behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
security
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.