swift-server / swift-server/async-http-client
deprecate `ignoreUncleanSSLShutdown: Bool` parameter
Nobody has claimed this yet.
- Dominant language
- Swift
- Stars
- 1.1k
- Forks
- 156
- PR merge metrics
- No merged PRs in 30d
Description
We should probably deprecate the ignoreUncleanSSLShutdown parameter. AsyncHTTPClient knows when it can and when it cannot ignore an unclean SSL shutdown.
Basically if an .end was received and we have either a content-length OR a transfer-encoding: chunked header from the server, we can safely ignore. For HTTP/2 we can always ignore.
If we do have neither a content-length, nor a transfer-encoding: chunked header, then this should error.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating AsyncHTTPClient's handling of the ignoreUncleanSSLShutdown parameter and the paths for HTTP/1 and HTTP/2 response completion. Check how .end, content-length, and transfer-encoding: chunked are currently interpreted. Done means the parameter is deprecated and unclean shutdowns follow the stated safe-ignore and error cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api, networking
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100