swift-server / swift-server/async-http-client

redirects behave strangely

Open
#195 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/enhancement
Dominant language
Swift
Stars
1.1k
Forks
156
PR merge metrics
No merged PRs in 30d

Description

When specifying a delegate, when executing a request that redirects, it appears that didSendRequest just happens again. Should we add a delegate method that tells the user a redirect is happening?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the delegate callback handling around redirects and the existing didSendRequest behavior. Determine whether repeated callbacks are expected, then define and verify the redirect notification behavior and its completion criteria with the relevant tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.