swagger-api / swagger-api/swagger-ui
Colors defined twice with no default options
Open
Nobody has claimed this yet.
cat: customization
cat: style & presentation
type: housekeeping
- Dominant language
- JavaScript
- Stars
- 29k
- Forks
- 9.3k
- Avg merge
- 2d 23h
- Merged PRs (30d)
- 25
Description
The actions colors defined here:
Are also defined here: https://github.com/swagger-api/swagger-ui/blob/master/src/style/_colors.scss
And without the !default key.
It make colors overriding impossible with main.scss integration. The only workaround is to import files one by one without the _colors.scss one.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the action color definitions in src/style/_variables.scss and src/style/_colors.scss, then inspect how main.scss integrates them. Done means the colors have one consistent, overridable definition when using the main.scss integration, without requiring individual imports.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- scss
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100