swagger-api / swagger-api/swagger-ui

Is ExclusiveMinimum/ExclusiveMaximum checked when creating the request

Open
#10,038 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
29k
Forks
9.3k
Avg merge
2d 23h
Merged PRs (30d)
25

Description

I have recently added support for ExclusiveMinimum/ExclusiveMaximum for Swashbuckle a C# library that uses Swagger-ui under the hood. It uses it and it provides a OpenApi document with the version 3.0.1. I do not know if the fields ExclusiveMinimum or ExclusiveMaximum have changed from the version 3.0.1, but with my PR the library now puts the values as a boolean value

When doing the request with a parameter that has a Maximum or Minimum with the exclusive value does not prevent me from doing it.
I have also test outside of the boundary and the page is preventing me from doing it.

The related issue:
domaindrivendev/Swashbuckle.AspNetCore#2957

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the request in Swagger UI with an OpenAPI 3.0.1 document using boolean ExclusiveMinimum or ExclusiveMaximum values, then trace the request validation entry point. Done means requests exactly on an exclusive boundary are rejected while values outside the boundary remain rejected as well.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, openapi
Domain
api, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.