swagger-api / swagger-api/swagger-parser

Undefined but required properties do not fail the validation

Open
#452 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Java
Stars
867
Forks
560
Avg merge
2d 21h
Merged PRs (30d)
7

Description

Description

The validation does not check whether a required property is actually part of the definition:
A message like Schema properties specified as 'required' must be defined is not created for the validation

Swagger-codegen version

2.2.2

Swagger declaration file content or url

In below the version is required but not a property:

  Sample:
    required:
      - name
      - version
    properties:
      name:
        type: string
Command line used for generation
Steps to reproduce
Related issues
Suggest a Fix

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the Swagger Parser 2.2.2 validation behavior with the Sample definition: version is listed under required but absent from properties. Trace the schema validation entry point and add coverage for the expected message that required properties must be defined; done means this invalid declaration produces that validation error.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend-api-design
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.