swagger-api / swagger-api/swagger-parser
dots lost when dereferencing files with dots
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 867
- Forks
- 560
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 7
Description
Hello
Following fix for https://github.com/swagger-api/swagger-parser/issues/1865 the name of the schema lost the dots
The name of the schema being of importance in the code generation, I think the swagger-parser should keep the dots as per the referenced file name
This mean that at
https://github.com/swagger-api/swagger-parser/blob/master/modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java#L115
I expect to see #/components/schemas/foo.model
instead of #/components/schemas/foomodel
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the dereferencing behavior covered near line 115 of modules/swagger-parser-v3/src/test/java/io/swagger/v3/parser/test/OpenAPIV3ParserTest.java, and read the fix referenced from issue 1865. Reproduce the case involving a referenced filename with dots, then update the behavior and test so the schema reference retains the dots, such as #/components/schemas/foo.model.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100