swagger-api / swagger-api/swagger-parser
swagger-parser-v2-converter converts overridden parameter incorrectly
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 867
- Forks
- 560
- Avg merge
- 2d 21h
- Merged PRs (30d)
- 7
Description
In OpenAPI v2, parameters can be defined in an operation and at the path item level. The precedence rule is stated in OpenAPI v2: "If a parameter is already defined at the Path Item, the new definition will override it, but can never remove it." That is, a definition at the operation level hides the corresponding definition at the path item level.
The swagger-parser-v2-converter, during conversion to v3, implements it the other way around.
How to reproduce:
- Store this file as v2.yaml.
- Store this file as ConvertOpenAPIV2ToV3.java.
Compile it with a classpath that contains
slf4j-api-1.5.8.jar
slf4j-jdk14-1.5.8.jar
jackson-core-2.9.9.jar
jackson-dataformat-yaml-2.9.9.jar
jackson-databind-2.9.9.jar
jackson-annotations-2.9.9.jar
commons-io-1.4.jar
commons-lang3-3.1.jar
swagger-models-2.0.8.jar
swagger-parser-v3-2.0.12.jar
swagger-core-2.0.8.jar
swagger-parser-core-2.0.12.jar
swagger-parser-v2-converter-2.0.12.jar
swagger-parser-1.0.44.jar
swagger-core-1.5.22.jar
swagger-models-1.5.22.jar
snakeyaml.jar
-
Run it with two arguments, namely the absolute file name from step 1 and the absolute file name of the destination file.
-
The output I got is:
As you can see, it has produced a parameter with type: string, where it should have produced a parameter with type: integer.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the swagger-parser-v2-converter entry point and reproduce the conversion using the attached v2.yaml and ConvertOpenAPIV2ToV3.java files. Compare the generated v3.yaml with the expected operation-level override, then verify that the overridden parameter retains type: integer rather than type: string.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100