swagger-parser-v2-converter removes properties from 'required' that are not explicitly listed

In OpenAPI v2 and v3, it is possible to declare, through 'additionalProperties: {}' or 'additionalProperties: true', that other properties can occur in an object than those explicitly listed in the schema. It can then make sense to specify that a property is required, even though it is not explicitly listed.

(Another way, maybe, to have properties that are not explicitly listed is to use the 'patternProperties' or 'x-patternProperties' regexes.)

The swagger-parser-v2-converter removes properties from 'required' that are not explicitly listed. It should not do that.

1. Store this file as v2.json.

v2.json.gz

2. Store this file as ConvertOpenAPIV2ToV3.java.

ConvertOpenAPIV2ToV3.java.gz

Compile it with a classpath that contains
slf4j-api-1.5.8.jar
slf4j-jdk14-1.5.8.jar
jackson-core-2.9.9.jar
jackson-dataformat-yaml-2.9.9.jar
jackson-databind-2.9.9.jar
jackson-annotations-2.9.9.jar
commons-io-1.4.jar
commons-lang3-3.1.jar
swagger-models-2.0.8.jar
swagger-parser-v3-2.0.12.jar
swagger-core-2.0.8.jar
swagger-parser-core-2.0.12.jar
swagger-parser-v2-converter-2.0.12.jar
swagger-parser-1.0.44.jar
swagger-core-1.5.22.jar
swagger-models-1.5.22.jar
snakeyaml.jar

3. Run it with two arguments, namely the absolute file name from step 1 and the absolute file name of the destination file.

4. The output I got is:

v3.json.gz

As you can see, the 'required' list of 'complexBoVerySpecial'

• in v2: contains "myDeepArray"
• in v3: does not contain "myDeepArray".

Start with the supplied ConvertOpenAPIV2ToV3.java and v2.json, then inspect the swagger-parser-v2-converter conversion path used by the reproducer. Run the conversion with the listed dependencies and compare the required list for complexBoVerySpecial; done means myDeepArray remains required in the v3 output.