swagger-api / swagger-api/swagger-codegen
Wrong usage of replaceAll when path is constructed
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Tested in context of : "library" set to "okhttp-gson".
There are two possible issue:
- in path parameter name can for some strange reason contains that matches to RegExp
- in path parameter value can contains other parameter name that could lead to replacement of wrong thing
Suggested to go throw the string to look up '{' replace part and continue for another one.
Maybe there is need for some extra escaping if some strange reason is needed in-path-parameter with "{", but all in all that should be cross-check by codegen generation in path and also in parameter name itself.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect the generated okhttp-gson client's path construction and locate the replaceAll usage. Reproduce the case with path parameter names or values containing regex-like text or another parameter name, then verify generated paths replace only the intended placeholders.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100