swagger-api / swagger-api/swagger-codegen
Eve ESI does not compile - rustc 1.38.0
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
EVE ESI -
Code generated by the latest codegen does not compile, and also spews tons of warnings.
Swagger-codegen version
2.4.10-SNAPSHOT
Swagger declaration file content or url
api spec taken from https://esi.evetech.net/_latest/swagger.json
as of 28 Oct 2019
Command line used for generation
mkdir /tmp/another-fail
java -jar modules/swagger-codegen-cli/target/swagger-codegen-cli.jar generate -i https://esi.evetech.net/_latest/swagger.json -l rust -o /tmp/another-fail
Steps to reproduce
- generate the code
- cd /tmp/another-fail ; cargo build
Suggest a fix/enhancement
A diff is attached of what I had to do to make it compile.
gentle.txt
Tons of warnings about "trait objects without an explicit dyn are deprecated". This has to be fixed.
Also tons of warnings about 'mut is not needed', although those can be ignored I guess.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Run the documented swagger-codegen command against the ESI swagger.json URL, then run cargo build in the generated /tmp/another-fail project to reproduce the compilation errors and warnings. Compare the result with gentle.txt and trace the Rust generator or templates responsible; done means the generated project compiles without the reported trait-object errors and avoids the unnecessary warnings.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100