swagger-api / swagger-api/swagger-codegen

[Ruby] Find sytanx in gemspec is not compatible with windows

Open
#9,461 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

The generated gemspec files use the following to generate the included files: find *.split("\n").uniq.sort.select { |f| !f.empty? } This command is not valid on Windows.

Suggest a fix/enhancement

Don't shell out to find. Use Ruby itself by replacing the find with: Dir.glob("**/*").sort

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the generator templates for gemspec output containing the shell-based find * command. Replace the command as suggested with Ruby's Dir.glob("**/*").sort, then verify that generated gemspec files use the Ruby glob and remain compatible with Windows.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
build-system, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.