swagger-api / swagger-api/swagger-codegen
[JAVA] Not all JSON.mustache template patched in swagger-codegen-cli
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
The changes of issue #4824 have been applied to the template file/Java/JSON.mustache within swagger-codegen-cli-3.0.8. However, the Jar-file contains several files of the same template and not all are patched. For instance, in my case /handlebars/Java/libraries/okhttp-gson/JSON.mustache will be chosen. And this does not have the ByteArrayAdapter.
Swagger-codegen version
swagger-codegen-cli-3.0.8
Swagger declaration file content or url
Command line used for generation
Steps to reproduce
Related issues/PRs
#4824
Suggest a fix/enhancement
Apply the changes of #4824 to every template where it makes sense.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare /Java/JSON.mustache with /handlebars/Java/libraries/okhttp-gson/JSON.mustache and review the related changes in #4824. Check the other Java JSON.mustache templates for the same missing change. Done means each applicable template includes the needed ByteArrayAdapter change and generated Java clients use the corrected template.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100