[go] Should not use pointer when HTTP post body type is string

Description

Swagger generated code is trying to get address of POST body. However, if body's type is string, such behavior will lead to sending an address to server.

func (c *MyClient) CreateObject(ctx context.Context, someOtherArgs, body string) (interface{},  *http.Response, error) {
    var (
        localVarHttpMethod = strings.ToUpper("Post")
        localVarPostBody interface{}
        localVarFileName string
        localVarFileBytes []byte
         successPayload  interface{}
    )

    // create path and map variables

    // to determine the Content-Type header

    // set Content-Type header

    // to determine the Accept header

    // set Accept header

    // body params
    localVarPostBody = &body

    // rest of the function
}

Swagger-codegen version

2.4.1
It's not a regression, and such problem appears in all current releases

Swagger declaration file content or url

Here is a simplified snippet

{
    "operationId": "createObject",
    "parameters": [
        {
            "description": "input",
            "in": "body",
            "name": "body",
            "required": true,
            "schema": {
                "type": "string"
            }
       }
    ]
}

Command line used for generation

generate -i my_swagger.json -l go -o my_directory

Steps to reproduce

I think this is a general problem - any HTTP POST body

Related issues/PRs

Suggest a fix/enhancement

Check argument type and decide whether to use pointer or not

Start by running the supplied generate command with the simplified Swagger JSON and inspect the generated Go client method, especially the POST body assignment. Trace the Go generator's body-parameter template or entry point to see how string types are handled. Done means generated HTTP POST code sends a string body correctly without taking its address, while other body types retain expected behavior.