swagger-api / swagger-api/swagger-codegen
[Swift4] Use thread safe manager dictionary
Open
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
Client crashes due to concurrent access of managerStore dictionary.
Swift2 and Swift3 had been enhanced respectively with the following pull requests:
#3873 #5610
Swagger-codegen version
2.3.1
Command line used for generation
swagger-codegen generate -i http://petstore.swagger.io/v2/swagger.json -l swift4
Related issues/PRs
#3873 #5610
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Swift4 generator templates and the managerStore references, then compare the related changes in PRs #3873 and #5610. Done means generated Swift4 clients no longer crash from concurrent access to managerStore; the issue does not name a test file or validation command beyond the generation command provided.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100