swagger-api / swagger-api/swagger-codegen
Symfony generated code is fatally broken for Symfony 4.1+
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
There are two major issues with Symfony generator that prevents using generated code with Symfony 4.1+, namely, composer dependency and unquoted parameters in services file. This prevents using generated bundle with Symfony 4.1+ even if it could be otherwise used, even in kind of sort of hackish way.
Swagger-codegen version
master
Suggest a fix/enhancement
I opened a pull request #8572 that should mitigate the two immediately blocking issues related to using generated bundle in Symfony 4. However, this should be considered more of a monkey patch than actual fix, because considering the major changes Symfony has underwent in v4, fixing this generator might not be a good idea anymore. Perhaps a new generator should be built for v4 specfically.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review pull request #8572 first, since it addresses the two reported Symfony 4.1 blockers. Confirm whether the composer dependency and unquoted service parameters are resolved, then determine whether Symfony 4 support needs a broader generator decision rather than a patch.
Written by the indexing model from the issue text.
Assessment
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 15/100