swagger-api / swagger-api/swagger-codegen

[Swift 4] - Allow setting different date decoding strategies

Open
#8,258 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
No merged PRs in 30d

Description

Description

I want to be able to set .iso8601 as a dateDecodingStrategy of JSONDecoder in CodableHelper.swift.

Swagger-codegen version

2.4.0

Suggest a fix/enhancement

In CodableHelper.swift:

  • Replace

    • open static var dateformatter: DateFormatter? with
    • open static var dateDecodingStrategy: JSONDecoder.DateDecodingStrategy?

  • And

    • if let df = self.dateformatter { decoder.dateDecodingStrategy = .formatted(df) // ... with
    • if let strategy = dateDecodingStrategy { decoder.dateDecodingStrategy = strategy // ...

Can you think of any downsides to this change?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in CodableHelper.swift and inspect how JSONDecoder.dateDecodingStrategy is currently assigned from dateformatter. Update the configuration to accept JSONDecoder.DateDecodingStrategy, including .iso8601, then verify that generated Swift clients decode dates using the selected strategy.

Written by the indexing model from the issue text.

Assessment

Tech stack
swift
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.