swagger-api / swagger-api/swagger-codegen

[typescript-angular] Update ng-packagr to latest 3.0.0

Open
#8,251 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

ng-packgr has been updated to 3.0.0 on 2018-05-25 closing several bugs (https://github.com/dherges/ng-packagr/blob/master/CHANGELOG.md#300-2018-05-25)

swagger-codegen should incorporate this. I've tested this with property ngVersion set to 6.0.0

Swagger-codegen version

2.4.0-20180525.184441-259

Suggest a fix/enhancement

Switch to the 3.0-branch of ng-packagr if version of Angular is >= 5.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named. Locate the typescript-angular configuration that declares ng-packagr, then check how Angular versions are selected and compare that with the requested 3.0 branch for Angular versions >=5. Done means the dependency selection is updated and the existing package-generation checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
angular, typescript
Domain
build-system
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.