swagger-api / swagger-api/swagger-codegen
[Swift 4] unwrapRequired option doesn't do anything
Open
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
It looks like the unwrapRequired config option doesn't do anything in Swift 4. It is there in Swift 3 generator but not in Swift 4. It's apparent by looking at the mustache templates for Swift 4 that that option doesn't exist anywhere in the templates.
Swagger-codegen version
2.3.1
Steps to reproduce
Readily reproducible in any project using this option and swift 4.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the Swift 3 generator's handling of the unwrapRequired option with the Swift 4 Mustache templates. Reproduce generation with unwrapRequired enabled, then update the Swift 4 templates so the option has the expected effect and verify the generated Swift output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100