swagger-api / swagger-api/swagger-codegen

[feign] character set encoding gets ascii code for json encoding

Open
#8,174 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

Code generator for feign generates ascii code for '=' sign in ApiClient

  @RequestLine("POST /pet")
  @Headers({
    "Content-Type: application/json; charset=ISO-8859-1",
    "Accept: application/json",
  })
  void addPet(Pet body);
Swagger-codegen version

2.3.1

Swagger declaration file content or url

https://gitlab.com/jigarshah/test-feign-client/blob/master/src/main/resources/petstore.yaml#L41

https://gitlab.com/jigarshah/test-feign-client

Command line used for generation
Steps to reproduce
Related issues/PRs
Suggest a fix/enhancement

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the generated Feign ApiClient from the petstore.yaml declaration with swagger-codegen 2.3.1. Inspect where the generated Content-Type header is assembled and compare the output for the '=' character. Done means the generated header contains the charset assignment as intended rather than an ASCII entity.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, openapi
Domain
api, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.