swagger-api / swagger-api/swagger-codegen
deferred.fulfill for a Promise<Void> has issue with latest PMK, Swift4 & Xcode 9
Open
Nobody has claimed this yet.
Client: Swift
help wanted
Issue: Bug
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Problem with your promises implementation....for the latest PromiseKit
for a Promise{Void}, you are generating:
deferred.fulfill( )
when you should generate
deferred.fulfill( () )
Note the extra parens as the void arg
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue concerns generated Swift PromiseKit code for Promise, specifically the deferred.fulfill output. Start by locating the Swift templates or generation entry point that emits this call, then verify the generated output uses the requested empty-tuple argument and test the affected client generation path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100