swagger-api / swagger-api/swagger-codegen

[typescript-angular2] Encodings differ by OS

Open
#6,971 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

When generating typescript/angular 2 files on OS X we get a different file encoding than when generating the same files on Windows 10. This is causing a lot of false positives when performing a diff using Visual Studio and git.

Swagger-codegen version

2.2.3

Swagger declaration file content or url
Command line used for generation

java swagger-codegen generate -i swagger.json -l typescript-angular2 -o ./src/app/proxy/

Steps to reproduce
Related issues/PRs
Suggest a fix/enhancement
  1. Default encoding that is the same for all operating systems.
  2. Generate option to override the default encoding when necessary.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the documented java swagger-codegen generate command with the typescript-angular2 generator on OS X and Windows 10, then compare the generated files' encodings. Trace how the generator writes those files and determine whether completion means a consistent default encoding or a command-line override option.

Written by the indexing model from the issue text.

Assessment

Tech stack
angularjs, java, typescript
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.