swagger-api / swagger-api/swagger-codegen

Update test cases for JSON MIME type detection

Open
#5,261 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: CI/Test help wanted
Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

We'll leverage the additional tests cases added via for other langauges (PHP, Ruby, etc) so as to ensure other API clients can also handle these edge cases.

Swagger-codegen version

Latest master

Related issues

https://github.com/swagger-api/swagger-codegen/pull/5189

Suggest a Fix

Test cases: https://github.com/davidharrigan/swagger-codegen/blob/c31d597747b99c08774105d5eab0ca9eacc0c593/samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/ApiClientTest.java#L80-L102

If anyone wants to work on this, please reply to let us know.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with samples/client/petstore/java/okhttp-gson/src/test/java/io/swagger/client/ApiClientTest.java, especially lines 80-102, and compare the cases added for PHP, Ruby, and other clients. Review related pull request 5189, then update the Java test coverage for JSON MIME type edge cases. Done means the relevant Java tests cover the intended detection behavior and pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.