swagger-api / swagger-api/swagger-codegen
Empty response body handling in typescript-angular2
Open
Nobody has claimed this yet.
Client: TypeScript
help wanted
Issue: Bug
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
Empty response 200 OK codes are not handled by auto generated api code.
Swagger-codegen version
2.2.2
Swagger declaration file content or url
Command line used for generation
language: typescript-angular2
Steps to reproduce
Build an api response just give 200 as http code but no response body
Suggest a Fix
Here's the current api.mustache at line 45;
return response.json()
It should be;
return response.json() || {};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with api.mustache around line 45, where the generated typescript-angular2 client parses the response body. Reproduce a 200 response with no body and verify the generated client handles it without failing; done means empty successful responses are handled correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angular, typescript
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100