[FINCH] Parameters in query are generated as path parameters

Description

The Finch code generator does not support query parameters correctly. They get generated as if they were path parameters.

Swagger-codegen version

2.2.2-SNAPSHOT

Swagger declaration file content or url

  /delivery/lookup/{clientId}/{appId}:
    get:
      tags:
        - Delivery
      operationId: lookup
      summary: Lookup
      description: Lookup
      parameters:
        - name: clientId
          type: string
          in: path
          required: true
          description: Client ID
        - name: appId
          type: string
          in: path
          required: true
          description: app id
        - name: url
          type: string
          in: query
          required: true
          description: page url to lookup
      responses:
        200:
          description: Response delivery object
          schema:
            $ref: '#/definitions/ResponseLookup'
        default:
          description: Unexpected error
          schema:
            $ref: '#/definitions/Error'

which generates

  private def lookup(da: DataAccessor): Endpoint[ResponseLookup] =
    get("delivery" :: "lookup" :: string :: string :: string) { (clientId: String, appId: String, url: String) =>
      Ok(da.Delivery_lookup(clientId, appId, url))
    } handle {
      case e: Exception => BadRequest(e)
    }

Suggest a Fix

The generator should instead generate

private def lookup(da: DataAccessor): Endpoint[ResponseLookup] =
    get("delivery" :: "lookup" :: string :: string :: param("url").as[String]) { (clientId: String, appId: String, url: String) =>
      Ok(da.Delivery_lookup(clientId, appId, url))
    } handle {
      case e: Exception => BadRequest(e)
    }

Start by inspecting the Finch generator's parameter mapping and the generated Scala endpoint shown in the issue. Compare path and query parameter handling, then verify that the url query parameter is generated as param("url").as[String] rather than as another path segment.