swagger-api / swagger-api/swagger-codegen
CSharp Import mapping
Nobody has claimed this yet.
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
I submitted #4405 a little while ago with the main aim to allow a derived generator to add .net project references into the packages.config and .csproj files. I just noticed today that the nancyfx generator has an import mapping feature added in c734a216. This solves the same problem of appending dependencies as I was attempting to solve with #4405, however I needed the feature in the csharp client sdk not the nancyfx server stub.
This brings me to two questions:
-
which method of import mapping is preferred (#4405 or c734a216)
-
shouldn't the preferred import mapping method be available to all .net generators while keeping the generators DRY as possible? If c734a216 is preferred then should the implementation code be moved to the AbstractCSharpGenerator?
Swagger-codegen version
curent master branch
Swagger declaration file content or url
N/A
Command line used for generation
N/A
Steps to reproduce
N/A
Related issues
N/A
Suggest a Fix
I am willing to do the PRs is necessary to implement whatever is decided. If #4405 is not the preferred method, i will close it.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Compare the import-mapping approach in #4405 with commit c734a216, focusing on the NancyFX generator and AbstractCSharpGenerator. Determine which approach should be shared by .NET generators, then confirm that the preferred mapping works for the CSharp client SDK without duplicating generator logic.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100