swagger-api / swagger-api/swagger-codegen

[aspnet5] Rename/deprecate aspnet5 for newer terminology

Open
#3,085 9 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Enhancement: General Server: C-Sharp
Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

Per Scott Hanselman's blog post, the server technology's name is no longer called ASP.NET 5 and is now called ASP.NET Core 1.0.

Rather than rename to aspnetcore or some variant, it would probably be best to create an aspnet server generator with library options for different versions (4.x, Core 1.0, Web Forms, etc.).

Swagger-codegen version

2.1.6

Swagger declaration file content or url

AspNet5ServerCodegen.java

Command line used for generation

N/A

Steps to reproduce

List languages, notice aspnet5:

swagger-codegen langs | tr -s " " "\n" | grep asp

Related issues

N/A

Suggest a Fix

Not sure how to 'deprecate' a language in favor of another. Maybe:

  • Rename AspNet5ServerCodegen to AspNetCoreCodegen
  • Set server language name in AspNetServerCodegen to aspnet
  • Create AspNet5ServerCodegen and extend from AspNetServerCodegen
  • Set server language name in AspNet5ServerCodegen to current aspnet5
  • Add AspNetServerCodegen to META-INF\services definition
  • Log a warning message in the constructor of AspNetServerCodegen, or otherwise indicate deprecation

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with AspNet5ServerCodegen.java and inspect the existing AspNetServerCodegen implementation and META-INF services definition. Review how server generators are listed by the langs command and how deprecation is represented elsewhere. Done means the newer ASP.NET Core terminology is available without breaking the existing aspnet5 entry.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
backend, tooling
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.