swagger-api / swagger-api/swagger-codegen
Swift GET parameters are not URL encoded
Open
Nobody has claimed this yet.
Client: Swift
help wanted
Issue: Bug
- Dominant language
- Mustache
- Stars
- 17.8k
- Forks
- 6k
- PR merge metrics
- No merged PRs in 30d
Description
Description
Generated Swift clients do not URL-encode GET parameters. This must be done if a GET parameter contains characters like slash ('/') or pipe ('|')
Swagger-codegen version
Swagger 2.2.0
Suggest a Fix
URL-encode all parameters by calling object.stringByAddingPercentEncodingWithAllowedCharacters(.URLHostAllowedCharacterSet())
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named in the issue; start by locating the Swift client templates that assemble GET parameters and reproduce the case using slash and pipe characters. Done means generated Swift clients percent-encode those parameter values, with coverage for these characters if the repository has relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- swift
- Domain
- api
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100