swagger-api / swagger-api/swagger-codegen

CVE-2018-16492 (High) detected in extend-3.0.0.tgz, extend-3.0.1.tgz

Open
#11,451 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

security vulnerability
Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

CVE-2018-16492 - High Severity Vulnerability

Vulnerable Libraries - extend-3.0.0.tgz, extend-3.0.1.tgz

extend-3.0.0.tgz

Port of jQuery.extend for node.js and the browser

Library home page: https://registry.npmjs.org/extend/-/extend-3.0.0.tgz

Path to dependency file: /samples/server/petstore/nodejs-google-cloud-functions/package.json

Path to vulnerable library: /samples/server/petstore/nodejs-google-cloud-functions/node_modules/extend/package.json,/samples/server/petstore/nodejs/node_modules/superagent/node_modules/extend/package.json

Dependency Hierarchy:

  • swagger-tools-0.10.1.tgz (Root Library)
    • superagent-1.8.5.tgz
      • extend-3.0.0.tgz (Vulnerable Library)
extend-3.0.1.tgz

Port of jQuery.extend for node.js and the browser

Library home page: https://registry.npmjs.org/extend/-/extend-3.0.1.tgz

Path to dependency file: /samples/client/petstore/typescript-node/npm/package.json

Path to vulnerable library: /samples/client/petstore/typescript-node/npm/node_modules/extend/package.json

Dependency Hierarchy:

  • request-2.85.0.tgz (Root Library)
    • extend-3.0.1.tgz (Vulnerable Library)

Found in HEAD commit: 4b7a8d7d7384aa6a27d6309c35ade0916edae7ed

Found in base branch: master

Vulnerability Details

A prototype pollution vulnerability was found in module extend <2.0.2, ~<3.0.2 that allows an attacker to inject arbitrary properties onto Object.prototype.

Publish Date: 2019-02-01

URL: CVE-2018-16492

CVSS 3 Score Details (9.8)

Base Score Metrics:

  • Exploitability Metrics:
    • Attack Vector: Network
    • Attack Complexity: Low
    • Privileges Required: None
    • User Interaction: None
    • Scope: Unchanged
  • Impact Metrics:
    • Confidentiality Impact: High
    • Integrity Impact: High
    • Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Origin: https://hackerone.com/reports/381185

Release Date: 2019-02-01

Fix Resolution (extend): 3.0.2

Direct dependency fix Resolution (swagger-tools): 0.10.2

Fix Resolution (extend): 3.0.2

Direct dependency fix Resolution (request): 2.86.0


  • Check this box to open an automated fix PR

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with /samples/server/petstore/nodejs-google-cloud-functions/package.json and /samples/client/petstore/typescript-node/npm/package.json, then inspect the dependency paths for swagger-tools, superagent, and request. Upgrade the direct dependencies to the listed fixed versions and verify that extend resolves to 3.0.2 in both sample trees.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js
Domain
security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.