swagger-api / swagger-api/swagger-codegen

CVE-2017-16116 (High) detected in string-3.3.3.tgz

Open
#11,393 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

security vulnerability
Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

CVE-2017-16116 - High Severity Vulnerability

Vulnerable Library - string-3.3.3.tgz

string contains methods that aren't included in the vanilla JavaScript string such as escaping html, decoding html entities, stripping tags, etc.

Library home page: https://registry.npmjs.org/string/-/string-3.3.3.tgz

Path to dependency file: /samples/server/petstore/nodejs/package.json

Path to vulnerable library: /samples/server/petstore/nodejs/node_modules/string/package.json,/samples/server/petstore/nodejs-google-cloud-functions/node_modules/string/package.json

Dependency Hierarchy:

  • swagger-tools-0.10.1.tgz (Root Library)
    • string-3.3.3.tgz (Vulnerable Library)

Found in HEAD commit: 4b7a8d7d7384aa6a27d6309c35ade0916edae7ed

Found in base branch: master

Vulnerability Details

The string module is a module that provides extra string operations. The string module is vulnerable to regular expression denial of service when specifically crafted untrusted user input is passed into the underscore or unescapeHTML methods.

Publish Date: 2018-06-07

URL: CVE-2017-16116

CVSS 3 Score Details (7.5)

Base Score Metrics:

  • Exploitability Metrics:
    • Attack Vector: Network
    • Attack Complexity: Low
    • Privileges Required: None
    • User Interaction: None
    • Scope: Unchanged
  • Impact Metrics:
    • Confidentiality Impact: None
    • Integrity Impact: None
    • Availability Impact: High

For more information on CVSS3 Scores, click here.

Suggested Fix

Type: Upgrade version

Origin: https://nvd.nist.gov/vuln/detail/CVE-2017-16116

Release Date: 2018-06-07

Fix Resolution: org.webjars.npm:underscore.string - 3.2.1;org.webjars.npm:string - 3.3.1;tslint - 4.5.1;MIDIator.WebClient - 1.0.105;EntityFramework.LookupTables - 1.1.14.119;underscore.string - 3.3.5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with /samples/server/petstore/nodejs/package.json and inspect the dependency paths listed for string-3.3.3.tgz, including the nodejs-google-cloud-functions installation. Check the suggested fixed versions and dependency resolution, then verify that the vulnerable string version is no longer present and the CVE is no longer detected.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
security
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.