swagger-api / swagger-api/swagger-codegen

JAVA-JAXRS parameters validation missing, openapi-generator discrepancy

Open
#11,119 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
17.8k
Forks
6k
PR merge metrics
No merged PRs in 30d

Description

Description

I am trying to figure out whether it is a good idea to use code generation for java-jaxrs, and which generator to use.
Wanted to understand why these changes in openapi-generator https://github.com/OpenAPITools/openapi-generator/commit/4d32e65c240189e253f9330656c2a9a4add97ba0 are not included in this project, and if those changes are useful how difficult it would be to include.

Swagger-codegen version

3.0.27

Swagger declaration file content or url
Command line used for generation

C:\java\jdk1.8.0_144\bin\java -jar swagger-codegen-cli.jar generate -i file.yml -l jaxrs-jersey -o .\folder `
--additional-properties useBeanValidation=true,date-library=java8

Steps to reproduce

Generate code, look at the service class

Related issues/PRs

https://github.com/OpenAPITools/openapi-generator/pull/3862

Suggest a fix/enhancement

Similar to
https://github.com/OpenAPITools/openapi-generator/commit/4d32e65c240189e253f9330656c2a9a4add97ba0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with the shown swagger-codegen command and inspect the generated java-jaxrs service class for missing parameter validation. Compare that output with the linked OpenAPI Generator commit and related pull request to determine which changes apply. Done means the discrepancy and a concrete implementation scope are established.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
api, backend
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.