swagger-api / swagger-api/swagger-codegen-generators

[SPRING] use discriminator's propertyName in @JsonTypeInfo annotation for mustache templates also

Open
#270 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
299
Forks
439
PR merge metrics
No merged PRs in 30d

Description

I see in commit #103 that discriminator is set to propertyName but see the fix only for handlebars and not mustache templates. Any reason for that?

Also swagger-codegen-generators says mustache is template engine by default for spring and scala generators. Can we have/merge the fix in #103 to mustache templates as well?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing commit #103 and comparing its handlebars fix with the mustache templates used by the Spring and Scala generators. Check how the @JsonTypeInfo discriminator is rendered in generated output. Done means the mustache templates use the discriminator's propertyName consistently with the handlebars templates.

Written by the indexing model from the issue text.

Assessment

Tech stack
scala, spring
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.