swagger-api / swagger-api/swagger-codegen-generators

[JavaSpring] Missing @Valid annotation for multipard/form-data content type if part is object

Open
#1,281 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
299
Forks
439
PR merge metrics
No merged PRs in 30d

Description

THe problem is located in mustache file FormData and it seems that @Valid annotation will only be added to file multipart file part but not to other parts which could be objects with their own required fields

Expected Result:

@Valid annotation is added during generation

Actual Result:
@Valid annotation is missing thus required fields inside model are not validated

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading src/main/resources/handlebars/JavaSpring/formParams.mustache, focusing on how annotations are selected for multipart file parts versus object parts. Generate a Java Spring multipart/form-data endpoint containing an object part and verify that @Valid appears on that part so its required fields are validated.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, spring
Domain
api, backend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.