swagger-api / swagger-api/swagger-codegen-generators

logback.xml not excluded in final jar artifact

Open
#1,015 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Mustache
Stars
299
Forks
439
PR merge metrics
No merged PRs in 30d

Description

Hello,

is there a particular reason to not exclude logback.xml from final jar artifact like it is done with swagger-codegen for instance

https://github.com/swagger-api/swagger-codegen/blob/3.0.0/modules/swagger-codegen/pom.xml

        <resources>
            <resource>
                <directory>src/main/resources</directory>
                <excludes>
                    <exclude>logback.xml</exclude>
                </excludes>
            </resource>
        </resources>

I use it as a dependency ( maybe I am wrong ) and I suspect it changed our default logging configuration

https://github.com/swagger-api/swagger-codegen-generators/blob/master/src/main/resources/logback.xml

    <root level="error">
        <appender-ref ref="STDOUT"/>
    </root>

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the Maven resource configuration that builds the final JAR and compare it with the referenced swagger-codegen pom.xml. Check whether logback.xml is included in the artifact and whether it changes dependency logging. Done means the resource is excluded from the final JAR without breaking the build.

Written by the indexing model from the issue text.

Assessment

Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.