sveltejs / sveltejs/kit

adapter-auto majors test doesn't run for the Version Packages PR

Open
#13,618 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

pkg:adapter-auto
Dominant language
JavaScript
Stars
20.8k
Forks
2.3k
Avg merge
1d 16h
Merged PRs (30d)
156

Description

Describe the problem

The adapter-auto package has a test to ensure that it pulls in the latest major version of the adapters it installs. However, this test isn't running when the github bot creates a Version Packages PR which updates those package version numbers. Instead, this test runs when we create a PR for adapter-auto to update the major versions it pulls in, but fails since the actual package versions are only updated in the Version Packages PR.

Describe the proposed solution

Ideally, the release GitHub action would update the major versions used by adapter-auto and also run the test.

Alternatives considered

No response

Importance

nice to have

Additional Information

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Trace the adapter-auto major-version test and the release GitHub action that creates Version Packages PRs. Reproduce the current ordering where the test runs before package versions are updated, then verify that the release flow updates adapter-auto and runs the test successfully in the resulting Version Packages PR.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, javascript
Domain
ci-cd, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.