sveltejs / sveltejs/devalue

Handle non-enumerable/writable/configurable properties

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
2.8k
Forks
99
Avg merge
3d 7h
Merged PRs (30d)
17

Description

Currently, devalue will ignore non-enumerable properties. It could use Object.getOwnPropertyDescriptors instead and handle those, correctly setting writable, enumerable and configurable.

With that, { foo: 1 } would just be the (common) special case where writable, enumerable and configurable are all true.

At the same time, we would throw on getters and setters, since devalue doesn't serialize functions.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue description and locate devalue's object-serialization entry point and existing tests. Check how non-enumerable properties and property descriptors are currently handled, then verify descriptor flags are preserved and getters or setters are rejected without serializing functions.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.