Mount points should take owner/mode

Open
#632 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
cli, infrastructure

Research direction

Start with the fly.toml [[mounts]] example and trace how mount configuration is parsed and passed through flyctl; the issue indicates that corresponding backend handling is also needed. Done means owner and mode are accepted for mounts and work with the shown Jupyter volume configuration.

Written by the indexing model from the issue text.

Description

enhancement good small task

Describe the bug
Jupyter's base image does weird things to create the directory notebooks are stored in, so the base image doesn't work with Fly volumes.

** Add fly.toml

[[mounts]]
  destination = "/home/jovyan"
  source = "home_jovyan"

This wants also fields for owner = "jovyan" and mode = "0750".

Obvs, this implies backend changes too. Annoying! But it will make some out-of-the-box Dockerhub images work with volumes.

Dominant language
Go
Stars
1.7k
Forks
311
Avg merge
12h 50m
Merged PRs (30d)
78

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from superfly/flyctl

All issues in superfly/flyctl

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.