`--attach` generates a toml with an odd structure

Open
#3,801 2 comments 0 reactions 1 assignee View on GitHub

@rubys is already working on this.

Since Jul 31, 2024.

Assessment

This issue has not been assessed yet.

Description

bug

Describe the bug

When I use the --attach flag, this is the fly.toml that I get in my fly/apps/<app-name>/fly.toml

[experimental]
  [experimental.attached]
    [experimental.attached.secrets]
      [experimental.attached.secrets.export]
        SANDWICH_CHAT_URL = 'http://${FLYCAST_URL}/sandwich-chat'

The relevant section of the original fly.toml for the attached app looks like this:

[experimental.attached.secrets.export]
  SANDWICH_CHAT_URL = "http://${FLYCAST_URL}/sandwich-chat"

Functionally this of course works, but it looks a bit weird.

Dominant language
Go
Stars
1.7k
Forks
311
Avg merge
12h 50m
Merged PRs (30d)
78

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from superfly/flyctl

All issues in superfly/flyctl

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.