Mixing `services.http_checks` with an `http_service` (and vice versa?) results in failing health checks

Open
#3,675 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
go
Domain
cli

Research direction

Start at the fly config validate command and trace the validation path for http_service and services.http_checks. Add coverage for a configuration that mixes these sections, and verify that validation reports an actionable error rather than allowing deployments with failing health checks.

Written by the indexing model from the issue text.

Description

bug

Describe the bug
Mistakenly mixing services.http_checks with an http_service (and possible vice versa, though I haven't tested) results in failing heath checks and therefore failing deployments.

fly config validate (and by extension, fly deploy) should check for this and fail gracefully.

[http_service]
  internal_port = 8080
  force_https = true
  auto_stop_machines = false
  auto_start_machines = true
  min_machines_running = 1
  processes = ['app']

  [[services.http_checks]]
    grace_period = "10s"
    interval = "30s"
    method = "GET"
    timeout = "5s"
    path = "/api/health"
Dominant language
Go
Stars
1.7k
Forks
311
Avg merge
12h 50m
Merged PRs (30d)
78

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from superfly/flyctl

All issues in superfly/flyctl

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.