Ftlctl generating wrong NodeJS environment Dockerfile

Open
#2,890 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
node.js
Domain
build-system, cli

Research direction

Start with the fly launch path that generates a Dockerfile for a Bun app, then compare its output with the Dockerfile linked from the bun-elysia example. Done means a Bun app receives a Bun-compatible Dockerfile and no longer fails with sh: 1: bun: not found.

Written by the indexing model from the issue text.

Description

bug

Please only report specific issues with flyctl behavior. Anything like a support request for your application should go to https://community.fly.io. More people watch that space and can help you faster!

Describe the bug
When using fly launch on a bun app, it breaks in WSL. Something about ".dockerfile ||="

image

I switched to powershell and used ftlctl from there. Launch worked. But now I had another problem, the app was crashing with error: sh: 1: bun: not found. It took some digging and finding dockerfile in this repo by codiplace (https://github.com/codiplace/bun-elysia) for my app to start running.

Bug: For some reason, the dockerfile generated was for NodeJS

  • Operating system
  • flyctl v0.1.104 linux/amd64 Commit: 682c341cb1b8fc0bc80589fd96d7cad34f1772f0 BuildDate: 2023-09-29T15:46:28Z
Dominant language
Go
Stars
1.7k
Forks
311
Avg merge
12h 50m
Merged PRs (30d)
78

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from superfly/flyctl

All issues in superfly/flyctl

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.