implement missing GraphQL spec validations
@olirice is already working on this.
Since Jan 5, 2024.
Assessment
This issue has not been assessed yet.
Description
The following validations are not currently performed by pg_graphql:
https://spec.graphql.org/October2021/#sec-Field-Selections
https://spec.graphql.org/October2021/#sec-Leaf-Field-Selections
https://spec.graphql.org/October2021/#sec-Argument-Names
https://spec.graphql.org/October2021/#sec-Argument-Uniqueness
https://spec.graphql.org/October2021/#sec-Fragment-Name-Uniqueness
https://spec.graphql.org/October2021/#sec-Fragments-On-Composite-Types
https://spec.graphql.org/October2021/#sec-Fragments-Must-Be-Used
https://spec.graphql.org/October2021/#sec-Fragment-spread-is-possible
https://spec.graphql.org/October2021/#sec-Input-Object-Field-Uniqueness
https://spec.graphql.org/October2021/#sec-Directives-Are-Defined
https://spec.graphql.org/October2021/#sec-Directives-Are-In-Valid-Locations
https://spec.graphql.org/October2021/#sec-Directives-Are-Unique-Per-Location
https://spec.graphql.org/October2021/#sec-Variable-Uniqueness
https://spec.graphql.org/October2021/#sec-Variables-Are-Input-Types
https://spec.graphql.org/October2021/#sec-All-Variables-Used
https://spec.graphql.org/October2021/#sec-All-Variable-Usages-are-Allowed
None of them are any blockers because the user has always an option to correct their query to avoid the behaviour due to missing validation but we should consider implementing them for better error messages and spec compliance.
- Dominant language
- Rust
- Stars
- 3.4k
- Forks
- 141
- Avg merge
- 19m
- Merged PRs (30d)
- 2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from supabase/pg_graphql
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
supabase/pg_graphql#646 ·
-
triage-required
supabase/pg_graphql#642 · 1 assignee ·
-
triage-required
supabase/pg_graphql#641 · 1 comment · 1 assignee ·
-
triage-required
supabase/pg_graphql#629 · 1 assignee ·
-
triage-required
supabase/pg_graphql#617 · 1 comment · 1 assignee ·
All issues in supabase/pg_graphql
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
kwakseongjae/auto-hwp#319 ·
-
area:cli bug filter-quality good first issue priority:medium
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
-
Difficulty 1/5 Under an hour Newbie friendliness 72/100
bevyengine/bevy#25861 ·
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
enhancement remote
Difficulty 2/5 1-3 hours Newbie friendliness 68/100