Should `make_fitswcs_header` set the `"DATE-AVG"` key?

Open
#8,400 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
api

Research direction

Start by reading the make_fitswcs_header entry point and how GenericMap uses the DATE-AVG and DATE-OBS keys. Determine whether adding DATE-AVG and allowing a different DATE-OBS value is compatible with the existing API; the issue is done when this design question has a decided, tested behavior.

Written by the indexing model from the issue text.

Description

Discussion Feature Request map

By default (at least on GenericMap), the "DATE-AVG" key is used as the obstime for the coordinate frame of the Map. However, we don't set this key on make_fitswcs_header. Should we? Is there any downside to doing this?

This is a standard FITS key and it is something we (optionally) rely on in GenericMap so I don't see any reason not to.

If we do do this, another option would be to consider allowing for setting "DATE-OBS" to be something other than the obstime of the reference coordinate.

Dominant language
Python
Stars
1k
Forks
682
Avg merge
1d 17h
Merged PRs (30d)
17

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from sunpy/sunpy

All issues in sunpy/sunpy

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.