How to set observer coordinate in a Map?
Nobody has claimed this yet.
Assessment
- Difficulty
- 5/5
- Estimated time
- Over a week
- Newbie friendliness
- 20/100
Research direction
Start by reading the decision in PR 3911 and the Map observer_coordinate property, then compare it with the existing FITS-keyword path using hgln_obs, hglt_obs, and dsun_obs. Define the supported user-facing way to apply a SkyCoord to existing maps and verify the resulting behavior with focused Map tests.
Written by the indexing model from the issue text.
Description
I currently have a lot of maps with missing observer coordinate information, and I would like to set this information to the location of the earth at the time the map was observed.
One way of doing this is to manually calculate what the values of the 'hgln_obs', 'hglt_obs', 'dsun_obs' FITS keywords should be, manually add them to the existing header, and create a new map. But I think a user should not have to worry about or know anything about FITS to do this.
Another way of doing this would be giving the observer_coordinate property a setter, and I could then set the observer coordinate to a SkyCoord (and internally sunpy would handle with the FITS stuff). But it has been decided not to support property setters on Map ☹️ (https://github.com/sunpy/sunpy/pull/3911)
So my questions are
- Should I learn FITS to do this?
- Should we revise the decision to not have any setters for
Map? - Is there another way to do this?
- Dominant language
- Python
- Stars
- 1k
- Forks
- 682
- Avg merge
- 1d 17h
- Merged PRs (30d)
- 17
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from sunpy/sunpy
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Feature Request net
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
net
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Documentation Effort Low Package Novice Priority Medium
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Effort Medium map Package Intermediate Priority Medium
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
bancolombia/sentinel#23 ·
-
test md OpenCI
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
langchain-ai/deepagents#6450 ·
-
bug client
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100