invalid_request_error mapped to CardException not InvalidRequestException

Open
#1,358 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
25/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
java
Domain
api

Research direction

Start in src/main/java/com/stripe/net/LiveStripeResponseGetter.java at handleApiError and inspect the status-402 mapping and nearby exception handling. Confirm that a 402 response whose body type is invalid_request_error is translated to InvalidRequestException rather than CardException, and update or add the relevant error-handling test if one exists.

Written by the indexing model from the issue text.

Description

breaking-api-change bug future
Describe the bug

handleApiError maps all 402 status code responses to CardException. We have received responses that in the Stripe dashboard are "type": "invalid_request_error", but result in a CardException. (The CardException has a null code which causes us problems.) An example of the Response body is shown further below.

I have been in touch with Stripe support who say "our error documentation doesn't map status codes to specific error types, so the invalid_request_error may not always go hand in hand with the 404 status code.". So I think handleApiError needs to allow for invalid_request_error type in the case 402: branch.

Example of Response body for invalid_request_error type which results in CardException:

Response body
{
  "error": {
    "message": "The payment is blocked because the used IBAN has been suspended. You can learn more about this at https://support.stripe.com/questions/sepa-debit-chargebacks-faq and if you need assistance processing a payment please contact us via https://support.stripe.com/contact/ for further information.",
    "type": "invalid_request_error"
  }
}
To Reproduce

Using the Charges API create a Charge with an underlying payment source where the associated IBAN has been disputed 3 times in row. Such that Stripe block the Charge and return an invalid_request_error response. See https://support.stripe.com/questions/sepa-debit-chargebacks-faq

Expected behavior

Expected the Stripe Java SDK to translate the invalid_request_error with HTTP status code 402 into an InvalidRequestException.
Actual behavior: CardException where only the message property is populated, notably not the code.

Code snippets

No response

OS

macOS

Java version

Java 11

stripe-java version

20.121.0

API version

2020-08-27

Additional context

At https://support.stripe.com/questions/sepa-debit-chargebacks-faq Stripe note this is new behavior since 2022-03-07. This is exactly consistent with when we started seeing this issue.

Dominant language
Java
Stars
1k
Forks
406
Avg merge
2d 18h
Merged PRs (30d)
20

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from stripe/stripe-java

All issues in stripe/stripe-java

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.