Performance optimization for some cases when using instancing
Open
Nobody has claimed this yet.
area-Graphics
enhancement
performance
priority-Medium
work-estimate-M
- Dominant language
- C#
- Stars
- 7.8k
- Forks
- 1.2k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 49
Description
A follow up on #741
Is your feature request related to a problem? Please describe.
When the material doesn't use a texture as normal map, the inverse world matrices are not required.
Describe the solution you'd like
Check the used material for HasNormalMap and only calculate inverse matrices when required.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the follow-up context in issue #741 and locating the instancing path that computes inverse world matrices. Trace how the material's HasNormalMap value is available, then verify that inverse matrices are skipped without a normal map and retained when one is present.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics, performance
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100