[Build] Shader key files should not be generated for .xksl in contentFiles folder of nuget
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 7.8k
- Forks
- 1.2k
- Avg merge
- 2d 17h
- Merged PRs (30d)
- 49
Description
Release Type:
official
Version:
398-beta01
Platform(s):
windows
Describe the bug
when adding a nuget that adds .xksl shader files to the .csproj via it's content folder, the shader key generator adds shader key files to the .csproj.
To Reproduce
Steps to reproduce the behavior:
-
make a normal nuget that has .xksl files in the contentFiles folder:
-
install/update this nuget -> shader key files get generated
Expected behavior
ignore .xksl files in contenFiles folder of nugets, or only pick up .xksl files in 'xenko' root folder of xenko dedicated nugets.
Screenshots
Log and callstacks
Additional context
building a nuget package that copies a bunch of files into the output/bin folder on build.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named. Reproduce on Windows with a NuGet package containing .xksl files in its contentFiles folder, then trace the shader key generator entry point; done means those files are ignored unless they are under the Xenko root of a dedicated package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system, game-dev
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100